Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout handling for slog messages #635

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

michael-methner
Copy link
Collaborator

  • Discard messages after timeout
  • Log warning message only once until a new slog message was logged
    successful

Signed-off-by: Michael Methner [email protected]

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <[email protected]>
@michael-methner
Copy link
Collaborator Author

Hello @ahmetfindi ,
can you please help me with this PR and verify this commit (i do not have QNX system at my hand). It is a improved fix from the commit which you have provided in PR #632 .

@minminlittleshrimp minminlittleshrimp changed the title [DRAFT] Fix timeout handling for slog messages Fix timeout handling for slog messages Jun 12, 2024
@michael-methner michael-methner merged commit 603f0e4 into master Jun 12, 2024
3 checks passed
alexmohr pushed a commit to mercedes-benz/dlt-daemon that referenced this pull request Jun 28, 2024
* Fix timeout handling for slog messages

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <[email protected]>

* Update src/dlt-qnx-system/dlt-qnx-slogger2-adapter.cpp

Co-authored-by: ahmetfindi <[email protected]>

---------

Signed-off-by: Michael Methner <[email protected]>
Co-authored-by: ahmetfindi <[email protected]>

Issue-ID: APRICOT-522230
Signed-off-by: Ahmet Findikci <[email protected]>
minminlittleshrimp pushed a commit that referenced this pull request Jul 2, 2024
* Fix timeout handling for slog messages

- Discard messages after timeout
- Log warning message only once until a new slog message was logged
  successful

Signed-off-by: Michael Methner <[email protected]>

* Update src/dlt-qnx-system/dlt-qnx-slogger2-adapter.cpp

Co-authored-by: ahmetfindi <[email protected]>

---------

Signed-off-by: Michael Methner <[email protected]>
Co-authored-by: ahmetfindi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants