Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #109: Fundamental types used in ifex_ast.py #110

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

mnlbm
Copy link
Contributor

@mnlbm mnlbm commented Feb 28, 2024

Author: Manuel Böhm <[email protected]>, on behalf of MBition GmbH.

Fix for issue #109: Fundamental types used in ifex_ast.py

Currently the fundamental types used in ifex_ast.py are only [str, int] and the code reflects that. To make the code more future-proof and complete further types are added.

Some other corner-cases and forgotten things might also still be here.


The program was tested solely for our own use cases, which might differ from yours.

The submission is provided under the main project license (LICENSE file in root of project).

Provider Information

@mnlbm mnlbm changed the title Fixes #109 Fixes #109: Fundamental types used in ifex_ast.py Feb 28, 2024
@gunnar-mb
Copy link
Collaborator

Squashed into single commit and signed-off, and pushed.

@gunnar-mb
Copy link
Collaborator

Automated tests failed for ifex_to_json_schema.py.
Found a small bug - the test for Any type lost when switching to is_simple_type() function.
Tests run OK now.

mnlbm and others added 2 commits March 19, 2024 16:30
Signed-off-by: Manuel Boehm <[email protected]>
Signed-off-by: Gunnar Andersson <[email protected]>
@gunnar-mb
Copy link
Collaborator

Rebased on master after #108 merge

@gunnar-mb
Copy link
Collaborator

All OK now. Thanks Manuel! Merging.

@gunnar-mb gunnar-mb merged commit 65095ac into COVESA:master Mar 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants