windows handling keyboard exception #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should add a comment that this is because of an Intel Fortran Library which by default adds a ConsoleCtrlHandler on Windows which crashes the program and using an environment variable, this can be disabled. (The 'FOR' in the variable stands for Fortran, fyi.) This seemed as the most reliable source for me: |
Closed
|
This PR should be merged only after the Current review process is done on PR #20 |
…and sys.path.append
|
I added a comment (also removing some redundant stuff that was added during the fixing process) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for windows command interrupt.
Now midi files are saved and ports are closed when a keyboard interrupt occurs. This was not the case before on windows.