Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBRD-25826] Improve astyle compatibility: -j option for brackets #5806

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vimkim
Copy link
Contributor

@vimkim vimkim commented Jan 14, 2025

http://jira.cubrid.org/browse/CBRD-25826

Purpose

code-style.sh의 astyle 명령어에서 버전 호환성 개선을 위해 --add-brackets 옵션을 -j로 변경합니다.

  • 최근 astyle이 2.0에서 3.0으로 버전업되면서, --add-brackets 옵션이 --add-braces로 변경되었습니다
  • -j는 두 옵션의 약어로서 모든 버전의 astyle에서 동작합니다
  • 이 변경으로 기존 기능을 유지하면서 이전 버전과 새로운 버전 모두에서 호환성을 확보할 수 있습니다

Implementation

- astyle --style=gnu --mode=c --indent-namespaces --indent=spaces=2 -xT8 -xt4 --add-brackets --max-code-length=120 --align-pointer=name --indent-classes --pad-header --pad-first-paren-out ${f}
+ astyle --style=gnu --mode=c --indent-namespaces --indent=spaces=2 -xT8 -xt4 -j --max-code-length=120 --align-pointer=name --indent-classes --pad-header --pad-first-paren-out ${f}

Remarks

다른 프로젝트에서도 유사한 변경이 있었습니다.

@vimkim vimkim self-assigned this Jan 14, 2025
@vimkim vimkim changed the title [CBRD-XXXXX] improve astyle compatibility: -j option for brackets [CBRD-25826] Improve astyle compatibility: -j option for brackets Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant