Fix docker init under linux #2836
Conversation
plugin/docker/src/main/java/com/perl5/lang/perl/idea/sdk/host/docker/PerlDockerAdapter.java
Show resolved
Hide resolved
| File remotePathFile = new File(remotePath); | ||
| String command = String.join(" ", DOCKER_EXECUTABLE, EXEC, INTERACTIVELY, containerName, | ||
| "tar", "hCcF", remotePathFile.getParent(), "-", remotePathFile.getName(), | ||
| "|", "tar", "Cxf", localPathFile.getParent(), "-"); |
There was a problem hiding this comment.
This is a separate feature, separate commit please with proper explanation.
Also needs test.
There was a problem hiding this comment.
Again, why do we need to have interactivity here?
There was a problem hiding this comment.
Interactively I mention in previous comment.
For test i dont know where are located tests for docker interaction can you point me where to add it.
There was a problem hiding this comment.
Dam, this may be tricky. Current integration tests supposed to be run with any interpreter - local, wsl or docker. And this is docker-specific test, so probably should be a separate class with unit test.
I have no example for this yet. You may describe the set up and I figure out the test later.
plugin/docker/src/main/java/com/perl5/lang/perl/idea/sdk/host/docker/PerlDockerAdapter.java
Show resolved
Hide resolved
|
Pls provide where is the test for docker integration in project thanks |
Fixing #2835