Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/241 #2844

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Dev/241 #2844

merged 12 commits into from
Apr 5, 2024

Conversation

hurricup
Copy link
Collaborator

@hurricup hurricup commented Apr 5, 2024

No description provided.

@hurricup
Migrated to the new transactional work with sdk
5899160 
- sdkType is need to be registered in plugin.xml
- all modifications to the additional data and encapsulated objects should be transactional
- make save and load safe, drop sdks with incorrect data
@hurricup hurricup enabled auto-merge (rebase) April 5, 2024 05:17
hurricup added 11 commits April 5, 2024 10:05
@hurricup
Build 2024.1
f0e4e9d
@hurricup
Renamed unreachable code inspection shortname to avoid clashes with g…
45d9760 
…eneric names (java particularly)
@hurricup
CAMELCADE-18679 Added explicit read action
9ad0067 
We don't have implicit read action anymore

#CAMELCADE-18679 Fixed
@hurricup
Fixed incorrect Pair class usage
2390ba1
@hurricup
Replaced layoutPolicy with layoutStrategy
9110bc7
@hurricup
JetBrains/pty4j#145 Disable conpty on windows
663ba14 
This is a temporary workaround until fix arrives in IDE, expected 2024.1.1
@hurricup
More windows control codes removal
5477567
@hurricup
#2842 Added explicit incompatibility with JBC product (remdev client)
311ce3b
@hurricup
Disabled FS access control for integration tests on windows
cde6e22 
For some time it does not allow to access `Cover.pm`
@hurricup
Moved generated element types to the parser package
f3dcfae 
This is necessary to migrate to the grammar-kit plugin 2022.3.2.2
It seems that it is wiping out lexer directory for some reason.
@hurricup
Migrated to the grammar-kit plugin 2022.3.2.2
3547fc8
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Qodana for JVM

2747 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 24
Missorted modifiers 🔶 Warning 613
Unused declaration 🔶 Warning 596
Deprecated API usage 🔶 Warning 253
Missing '@Override' annotation 🔶 Warning 212
Method can be made 'void' 🔶 Warning 78
Check dependency licenses 🔶 Warning 77
Method parameter always has the same value 🔶 Warning 46
Method always returns the same value 🔶 Warning 45
Hardcoded strings 🔶 Warning 36
@NotNull/@Nullable problems 🔶 Warning 36
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 27
Class is exposed outside of its visibility scope 🔶 Warning 25
Static initialization in extension point implementations 🔶 Warning 25
Method is identical to its super method 🔶 Warning 21
Unnecessary semicolon 🔶 Warning 21
Can use bounded wildcard 🔶 Warning 19
Declaration can have 'final' modifier 🔶 Warning 16
Non-platform TokenSet declared in ParserDefinition 🔶 Warning 16
Redundant 'throws' clause 🔶 Warning 13
Field may be 'final' 🔶 Warning 9
C-style array declaration 🔶 Warning 7
'final' method in 'final' class 🔶 Warning 3
Missing required 'lang' attribute 🔶 Warning 3
Raw use of parameterized class 🔶 Warning 3
Incorrect string capitalization 🔶 Warning 2
A service can be converted to a light one 🔶 Warning 2
Statement lambda can be replaced with expression lambda 🔶 Warning 1
Explicit type can be replaced with '<>' 🔶 Warning 1
Lambda can be replaced with method reference 🔶 Warning 1
Plugin.xml dynamic plugin verification 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 505
Method can be extracted ◽️ Notice 5
Immutable collection creation can be replaced with collection factory call ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@hurricup hurricup merged commit dc5fd99 into master Apr 5, 2024
36 checks passed
@hurricup hurricup deleted the dev/241 branch April 5, 2024 06:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.4% Coverage on New Code (required ≥ 70%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hurricup