Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace istanbul by nyc as code coverage tool #714

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Replace istanbul by nyc as code coverage tool #714

merged 4 commits into from
Jan 3, 2020

Conversation

dgaubert
Copy link
Contributor

@dgaubert dgaubert commented Jan 2, 2020

No description provided.

@dgaubert dgaubert requested a review from Algunenano January 2, 2020 16:35
@Algunenano
Copy link
Contributor

jshint is complaning about I'm not sure what since /srv/test/results/compare-lib/js/coveringBad.js doesn't make sense to me.

@dgaubert
Copy link
Contributor Author

dgaubert commented Jan 3, 2020

🤔
53a4b31

Algunenano
Algunenano reviewed Jan 3, 2020
View reviewed changes
Copy link
Contributor

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know Windshaft had submodules. Do we even need that? Have you ever used the compare.html?

@dgaubert
Copy link
Contributor Author

dgaubert commented Jan 3, 2020

I didn't use it before. I even did NOT aware of that. I guess we can remove it as it's a tool to see pixel diff when tests fail

@Algunenano
Copy link
Contributor

🔥 We can always recover it in the future if the need it (and remember it existed at some point).

@dgaubert
Copy link
Contributor Author

dgaubert commented Jan 3, 2020

I'll do it in a separate PR, do you agree?

@dgaubert
Copy link
Contributor Author

dgaubert commented Jan 3, 2020

#717

@dgaubert dgaubert requested a review from Algunenano January 3, 2020 16:26
@Algunenano
Copy link
Contributor

All good

@dgaubert dgaubert changed the base branch from eslint to master January 3, 2020 16:30
@dgaubert dgaubert merged commit 30c8da0 into master Jan 3, 2020
@dgaubert dgaubert deleted the nyc branch January 3, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Algunenano Algunenano Awaiting requested review from Algunenano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgaubert @Algunenano