Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove argument links to criterion #71

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

sfluegel05
Copy link
Collaborator

In #69, I added links between chebi_version arguments. This way, you only need to type in the chebi version once and avoid the potential for e.g. the semantic loss checking for inconsistencies in version 200, while the training data is from version 231.

However, this leads to issues when someone is using a different loss function than BCEWeighted. Then, the link leads to an argument of the loss function that does not exist, causing an error in jsonargparse (the error is shown as an IndexError, but that is the error it raises while trying to generate an error message, not the actual error).

For now, I removed the argument linking.

@sfluegel05
Copy link
Collaborator Author

@schnamo Could you please check if this solves your problem with the chebai dev branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant