-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove npm badge from README #6412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6412 +/- ##
=========================================
Coverage 61.72% 61.72%
=========================================
Files 553 553
Lines 57858 57858
Branches 1829 1829
=========================================
Hits 35714 35714
Misses 22107 22107
Partials 37 37 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Feb 8, 2024
🎉 This PR is included in v1.16.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have a big red warning in our docs to not use the CLI package
But at the same time we have a badge that links to the package on top of the README alongside docker and github (source). Until we fix the npm supply chain issue I'd suggest to remove that and not advocate for npm installation.
There is also already a reference to the CLI package in the Architecture Overview
Description
Remove npm badge from README