Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WalletSend component #78

Merged
merged 6 commits into from
Jan 7, 2025
Merged

feat: add WalletSend component #78

merged 6 commits into from
Jan 7, 2025

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Dec 18, 2024

No description provided.

Copy link
Collaborator

@krzysu krzysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, but please don't reuse WalletBalance inside TokenSelect as WalletBalance is changing to look like below.

Screenshot 2024-12-16 at 11 02 16

@krzysu krzysu changed the title Send flow feat: add WalletSend component Dec 18, 2024
]);

return {
balances: (balancesRes?.data?.tokenBalances ?? []) as WalletTokenBalance[],
wallet: walletRes?.data?.wallet as Wallet,
transactions: (transactionsRes?.data?.transactions ?? []) as Transaction[],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving transaction loading from server to client requires handling loading state in the client, but let's take care of that later. all client side loading should be refactored to hooks, but we can handle that later too.

@krzysu
Copy link
Collaborator

krzysu commented Jan 7, 2025

@avkos there are some linting issues, please fix before merging

@avkos avkos merged commit a39fc41 into main Jan 7, 2025
2 checks passed
@avkos avkos deleted the ok/send-flow branch January 7, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants