Unify and update TypeScript, ESLint and yarn version + fix detected eslint issues #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Muhammad-Altabba
commented
Dec 19, 2024
Muhammad-Altabba
commented
- Unified and updated library versions, specifically TypeScript and ESLint, across all projects.
- Fixed and ignored linting issues in the SDK.
- Updated Yarn as the Package Manager from version 1.22.22 to 4.5.3.
Muhammad-Altabba
requested review from
avkos,
krzysu,
danforbes,
luu-alex and
jdevcs
and removed request for
avkos and
krzysu
Muhammad-Altabba
force-pushed
the
80-unify-and-update-typescript-eslint-and-yarn-version
branch
from
b9fe506 to
a4d12df
Compare
Muhammad-Altabba
force-pushed
the
80-unify-and-update-typescript-eslint-and-yarn-version
branch
from
a4d12df to
a6a9494
Compare
avkos
approved these changes
Dec 20, 2024
Muhammad-Altabba
deleted the
80-unify-and-update-typescript-eslint-and-yarn-version
branch
krzysu
reviewed
Jan 6, 2025
| @@ -14,6 +14,7 @@ | |||
| "build-storybook": "storybook build" | |||
| }, | |||
| "dependencies": { | |||
| "@chainsafe/eslint-config": "^2.2.4", | |||
There was a problem hiding this comment.
why adding this if it is not used anywhere? I don't see this added to eslint configuration file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.