Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup the repo after recent yarn upgrade :/ #85

Closed
wants to merge 1 commit into from

Conversation

krzysu
Copy link
Collaborator

@krzysu krzysu commented Jan 7, 2025

No description provided.

.prettierrc Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier config name change is required for new yarn version to pickup prettier config and stop it from reformatting package.json on each yarn run

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why yarn source code should be stored inside our repo, could you explain @Muhammad-Altabba ?

@@ -14,7 +14,6 @@
"build-storybook": "storybook build"
},
"dependencies": {
"@chainsafe/eslint-config": "^2.2.4",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was added but never used

@krzysu krzysu force-pushed the yarn-upgrade-cleanup branch 2 times, most recently from ed87e09 to ae78a40 Compare January 7, 2025 14:03
@krzysu krzysu force-pushed the yarn-upgrade-cleanup branch from ae78a40 to 52ee4d2 Compare January 7, 2025 14:06
@krzysu
Copy link
Collaborator Author

krzysu commented Jan 7, 2025

this doesn't work, I give up

@krzysu krzysu closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant