16901 FIX nagios-plugins:check_ping: custom-command not mapped to 'ch…

…eck_ping' resulting in wrong time units displayed

Having an 'Integrate Nagios plug-ins' rule configured to call
'check_ping' but having the actual value for 'Command line' not start
with 'check_ping' or './check_ping' wouldn't have it recognized
correctly resulting in ms wrongly interpreted as seconds.
This change also allows the command to contain '/check_ping' in order to
recognize more ways to write the custom command and thus displaying
correct units.

SUP-21238

Change-Id: Iac2987ffbde8c5d2b5a91495a1d5a7528b96646a

.werks/16901

@@ -0,0 +1,14 @@
+Title: nagios-plugins:check_ping: custom-command not mapped to 'check_ping' resulting in wrong time units displayed
+Class: fix
+Compatible: compat
+Component: checks
+Date: 1731940191
+Edition: cre
+Level: 1
+Version: 2.2.0p38
+
+Having an 'Integrate Nagios plug-ins' rule configured to call 'check_ping' but having the actual
+value for 'Command line' not start with 'check_ping' or './check_ping' wouldn't have it recognized
+correctly resulting in ms wrongly interpreted as seconds.
+This change also allows the command to contain '/check_ping' in order to recognize more ways
+to write the custom command and thus displaying correct units.

cmk/gui/plugins/metrics/utils.py

@@ -429,7 +429,8 @@ def _parse_check_command(check_command: str) -> str:
     # This function handles very special and known cases.
     parts = check_command.split("!", 1)
     if parts[0] == "check-mk-custom" and len(parts) >= 2:
-        if parts[1].startswith("check_ping") or parts[1].startswith("./check_ping"):
+        # re.search(r"(^|/)check_ping(\s|$)", parts[1]) would be better..
+        if parts[1].startswith("check_ping") or "/check_ping" in parts[1]:
             return "check_ping"
     return parts[0]