Merge pull request #1245 from zoglo/fix/shift-key-navigation

Fix `shift` key handling when navigating with `tab`
Choices-js · Dec 22, 2024 · 00225b6 · 00225b6
2 parents 4d82380 + d3afeba
commit 00225b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/scripts/choices.ts b/src/scripts/choices.ts
@@ -1606,15 +1606,15 @@ class Choices {
       event.key === 'Unidentified';
 
     /*
-      We do not show the dropdown if the keycode was tab or esc
-      as these one are used to focusOut of e.g. select choices.
+      We do not show the dropdown if focusing out with esc or navigating through input fields.
       An activated search can still be opened with any other key.
      */
     if (
       !this._isTextElement &&
       !hasActiveDropdown &&
       keyCode !== KeyCodeMap.ESC_KEY &&
-      keyCode !== KeyCodeMap.TAB_KEY
+      keyCode !== KeyCodeMap.TAB_KEY &&
+      keyCode !== KeyCodeMap.SHIFT_KEY
     ) {
       this.showDropdown();
 

diff --git a/src/scripts/interfaces/keycode-map.ts b/src/scripts/interfaces/keycode-map.ts
@@ -1,5 +1,6 @@
 export const KeyCodeMap = {
   TAB_KEY: 9,
+  SHIFT_KEY: 16,
   BACK_KEY: 46,
   DELETE_KEY: 8,
   ENTER_KEY: 13,