Fix tab => direction keys handling in single-select mode
#1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was changed after the function call
Xon
force-pushed
the
fix-tab-direction-keys
branch
from
fea0276 to
08c6ce8
Compare
zoglo
suggested changes
Dec 22, 2024
Comment on lines
4889
to
4896
| var targetIsInput = target === this.input.element; | ||
| if (this._isTextElement || this._isSelectMultipleElement) { | ||
| if (targetIsInput) { | ||
| containerOuter.removeFocusState(); | ||
| this.hideDropdown(true); | ||
| this.unhighlightAll(); | ||
| } | ||
| } | ||
| else { | ||
| if (targetIsInput) { | ||
| containerOuter.removeFocusState(); | ||
| if (targetIsInput || (target === containerOuter.element && !this._canSearch)) { | ||
| this.hideDropdown(true); | ||
| this.hideDropdown(true); | ||
| if (this._isTextElement || this._isSelectMultipleElement) { | ||
| this.unhighlightAll(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Whilst this works for the search not being hidden, we now don't take into account to remove the focusState on the previous outerElement when tabbing through. The previous element won't lose their is-focused class.
We'd actually need to check for another condition afterwards to remove the previous class:
if (target === this.input.elemen) {
// your logic
}
// Remove the focus state when the past outerContainer was the target
else if (target === this.containerOuter.element) {
containerOuter.removeFocusState();
}There was a problem hiding this comment.
I've restored that else branch, and compiled the js files. Want to give that a test to see if that encounters any other regressions or accessibility issues?
There was a problem hiding this comment.
Already did (testing), the change looks good to me :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.