Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Change Parametrized system over to caskade #275

Merged
merged 22 commits into from
Nov 21, 2024
Merged

Conversation

ConnorStoneAstro
Copy link
Member

Parametrized has been extracted from caustics and improved into the new caskade system. This PR ports caustics over to the new functionality.

@ConnorStoneAstro ConnorStoneAstro added the refactor A code change that neither fixes a bug nor adds a feature label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 88.73786% with 58 lines in your changes missing coverage. Please review.

Project coverage is 90.30%. Comparing base (762de12) to head (93eccaa).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/caustics/utils.py 52.94% 24 Missing ⚠️
src/caustics/lenses/point.py 57.89% 8 Missing ⚠️
src/caustics/lenses/base.py 93.75% 5 Missing ⚠️
src/caustics/lenses/tnfw.py 83.33% 5 Missing ⚠️
src/caustics/lenses/singleplane.py 50.00% 4 Missing ⚠️
src/caustics/cosmology/base.py 88.88% 3 Missing ⚠️
src/caustics/light/pixelated_time.py 40.00% 3 Missing ⚠️
src/caustics/lenses/func/point.py 60.00% 2 Missing ⚠️
src/caustics/lenses/nfw.py 90.00% 2 Missing ⚠️
src/caustics/sims/simulator.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #275      +/-   ##
==========================================
- Coverage   93.59%   90.30%   -3.30%     
==========================================
  Files          64       55       -9     
  Lines        2953     2280     -673     
==========================================
- Hits         2764     2059     -705     
- Misses        189      221      +32     
Flag Coverage Δ
unittests 90.30% <88.73%> (-3.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ConnorStoneAstro ConnorStoneAstro marked this pull request as ready for review October 24, 2024 18:52
@ConnorStoneAstro
Copy link
Member Author

Remember to change order of lens source so that z_s goes before the modules

Copy link
Collaborator

@AlexandreAdam AlexandreAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome stuff!

__all__ = ("BatchedPlane",)


class BatchedPlane(ThinLens):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awsome!

src/caustics/lenses/batchedplane.py Show resolved Hide resolved
@ConnorStoneAstro ConnorStoneAstro merged commit e363304 into dev Nov 21, 2024
10 of 13 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the getcaskade branch November 21, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants