-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change Parametrized system over to caskade #275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #275 +/- ##
==========================================
- Coverage 93.59% 90.30% -3.30%
==========================================
Files 64 55 -9
Lines 2953 2280 -673
==========================================
- Hits 2764 2059 -705
- Misses 189 221 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Remember to change order of lens source so that z_s goes before the modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awsome stuff!
__all__ = ("BatchedPlane",) | ||
|
||
|
||
class BatchedPlane(ThinLens): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awsome!
Parametrized
has been extracted from caustics and improved into the newcaskade
system. This PR ports caustics over to the new functionality.