Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Webpack server with Vite KER-404 #1093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace Webpack server with Vite KER-404 #1093

wants to merge 1 commit into from

Conversation

mikkojamG
Copy link
Contributor

@mikkojamG mikkojamG commented Nov 5, 2024 •
edited
Loading

Replacing old Webpack server solution with Vite.

  • Replace Jest with Vitest
  • Update runtime envs with a script
  • Replace old toml configuration files with .env
  • Remove multiple unneeded dependencies

Requires changes to UI config map: https://dev.azure.com/City-of-Helsinki/kerrokantasi/_git/kerrokantasi-pipelines/pullrequest/9987

Fixes multiple vulnerabilities:

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@mikkojamG mikkojamG changed the title [DRAFT] feat: remove webpack, add Vite and Vitest KER-404 [DRAFT] Replace Webpack server with Vite KER-404 Nov 6, 2024
@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch 2 times, most recently from 23c9f73 to 02fa76e Compare November 7, 2024 08:53
@mikkojamG mikkojamG changed the title [DRAFT] Replace Webpack server with Vite KER-404 Replace Webpack server with Vite KER-404 Nov 7, 2024
@mikkojamG mikkojamG marked this pull request as ready for review November 7, 2024 08:58
@mikkojamG mikkojamG requested review from arpargo and a team November 7, 2024 08:58
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

arpargo
arpargo previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@arpargo arpargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is failed for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@mikkojamG mikkojamG requested a review from arpargo December 19, 2024 11:01
@mikkojamG mikkojamG force-pushed the feat/KER-404-vite branch 2 times, most recently from e2b901f to 7452433 Compare December 19, 2024 12:09
@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@terovirtanen
Copy link
Contributor

KERROKANTASI-UI branch is deployed to platta: https://kerrokantasi-pr1093-ui.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

e2e tests result is success for https://kerrokantasi-pr1093-ui.dev.hel.ninja 😆🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpargo arpargo Awaiting requested review from arpargo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkojamG @terovirtanen @arpargo