refactor(cc-addon-elasticsearch-options): feedback Pierre (fixup later)

CleverCloud · Jan 13, 2025 · 76d1fc0 · 76d1fc0
1 parent b4ef1ba
commit 76d1fc0
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/components/cc-addon-elasticsearch-options/cc-addon-elasticsearch-options.js b/src/components/cc-addon-elasticsearch-options/cc-addon-elasticsearch-options.js
@@ -90,7 +90,7 @@ export class CcAddonElasticsearchOptions extends LitElement {
    *
    * @param {boolean} skeleton - Whether the component is in loading state
    * @param {boolean} hasMonthlyCost - Whether monthly cost should be included
-   * @param {Flavor|FlavorWithMonthlyCost} [flavor] - The flavor object to return if not in skeleton state
+   * @param {Flavor|FlavorWithMonthlyCost} flavor - The flavor object to return if not in skeleton state
    * @returns {Flavor|FlavorWithMonthlyCost} The appropriate flavor object
    */
   _getElasticsearchOptionFlavor(skeleton, hasMonthlyCost, flavor) {

diff --git a/src/components/cc-addon-elasticsearch-options/cc-addon-elasticsearch-options.stories.js b/src/components/cc-addon-elasticsearch-options/cc-addon-elasticsearch-options.stories.js
@@ -83,6 +83,32 @@ export const loading = makeStory(conf, {
   ],
 });
 
+export const loadingWithNoMonthlyCost = makeStory(conf, {
+  /** @type {Partial<CcAddonElasticsearchOptions>[]} */
+  items: [
+    {
+      state: {
+        type: 'loading',
+        hasMonthlyCost: false,
+        options: [
+          {
+            name: 'kibana',
+            enabled: false,
+          },
+          {
+            name: 'apm',
+            enabled: false,
+          },
+          {
+            name: 'encryption',
+            enabled: false,
+          },
+        ],
+      },
+    },
+  ],
+});
+
 export const dataLoadedWithPreselectedKibana = makeStory(conf, {
   /** @type {Partial<CcAddonElasticsearchOptions>[]} */
   items: [