Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clever native KV support #725

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Clever native KV support #725

merged 3 commits into from
Dec 18, 2024

Conversation

davlgd
Copy link
Contributor

@davlgd davlgd commented Apr 16, 2024 •
edited
Loading

⚠️ This is an experimental project to show how easy it is to include native MateriaKV DB support to an application through the Redis API compatiblity layer ⚠️

Documentation is available here.

@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch from e70e4cc to 8ed0881 Compare April 16, 2024 17:06
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

🔎 A preview has been automatically published:

  • 🐧 linux 02b967070d6b343424cb2d1f6c57cf3946776dadf05a0f8548acc37be0c46c36
  • 🍏 macos 5c5b5961b069886c74e91fa61461ce4e94a7382ebfe7dab75eb43f8b366738b6
  • 🪟 win 6e92d2f5bd3135bb992efa05ceebd2f310c94d5d9f33d29f96a9a4104a5545d2

This preview will be deleted once this PR is closed.

@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 4 times, most recently from f810641 to 2b66000 Compare April 19, 2024 16:21
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 2 times, most recently from 1523057 to 5ae5634 Compare May 29, 2024 20:39
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 5 times, most recently from 94bd002 to 6b53f57 Compare June 11, 2024 11:26
@hsablonniere hsablonniere added this to the Experiments milestone Jun 20, 2024
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 2 times, most recently from 37f8ab4 to 870a462 Compare July 1, 2024 22:18
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch from 870a462 to ad6341f Compare August 16, 2024 07:57
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 2 times, most recently from 807a067 to 8da9b12 Compare October 23, 2024 13:57
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch 2 times, most recently from 800b757 to 7f90d65 Compare December 2, 2024 21:59
pdesoyres-cc
pdesoyres-cc previously requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@pdesoyres-cc pdesoyres-cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. I have some minor comments. I'm ok with this simple implementation.

We clearly have work to do around addon Ids resolution accros all commands related to addons.

bin/clever.js Outdated Show resolved Hide resolved
src/models/ids-resolver.js Outdated Show resolved Hide resolved
src/commands/kv.js Show resolved Hide resolved
docs/kv.md Outdated Show resolved Hide resolved
@davlgd davlgd marked this pull request as ready for review December 3, 2024 19:32
@davlgd davlgd requested a review from a team as a code owner December 3, 2024 19:32
@davlgd davlgd changed the title [PoC] Clever native KV support Clever native KV support Dec 3, 2024
@davlgd davlgd force-pushed the davlgd-embedded-kv-client branch from 74cb92f to 9f6a4ee Compare December 6, 2024 18:23
@hsablonniere hsablonniere force-pushed the davlgd-embedded-kv-client branch from 9f6a4ee to 3a173c5 Compare December 18, 2024 14:03
hsablonniere
hsablonniere approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@hsablonniere hsablonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hsablonniere hsablonniere merged commit 04f3826 into master Dec 18, 2024
5 checks passed
@hsablonniere hsablonniere deleted the davlgd-embedded-kv-client branch December 18, 2024 14:15
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdesoyres-cc pdesoyres-cc pdesoyres-cc left review comments

@hsablonniere hsablonniere hsablonniere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0 (experimental feature system w...
Development

Successfully merging this pull request may close these issues.
3 participants
@davlgd @hsablonniere @pdesoyres-cc