-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guides: Add instructions for multiple SSG tools #122
Conversation
Update hugo.md
Deployment has finished 👁️👄👁️ Your app is available here |
Build folderUpdate: after running some tests, that seems to be an issue in our Node runtime, and not Static.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find all these new guides amazing. Thanks for all this work.
Only change to ensure presentation consistency and readability is to replace the title by the framework name, and we should be good to go.
I'm not sure so short titles will be good for SEO. Can you check with marketing team? |
It's not a SEO but a readability issue. Readability and clarity in sidebar for the doc is always privileged, and yes, even over SEO. Check the rest of the titles in |
The metadata is not enough for a good SEO strategy, that's my point. We also need these guides to be found/read. I agree on the importance of readability, but it can't be only one or the other. It's why I asked to involve marketing team to reach a consensus on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace path to avoid hiding frameworks in another level and let them be indexed by alphabetical order as intended for this page.
Head of Marketing has already approved the structure of this page when building the site and restructuring the doc. It took a lot of discussions and research. This subject has already been covered. |
If it's ok for marketing team, it's ok for me |
🚀 Your app has been updated and is available here |
58aa3f5
to
5802112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subjects left:
- Do we need a partial for the cards, since we a a single level in
/guides/_index/md
? - Subtitle partial missing to keep the look consistent
I can do these changes after merging and before pushing to prod, it's not a big issue
There were some conflicts in |
It's ok for me @juliamrch |
Your review app has been deleted 👋 |
Checklist
Pull request type
Please check the type of change your PR introduces:
Description
New guides for multiple SSG:
I used partials for shared instructions and added SVG icons
Reviewes
Who should review these changes? @