Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog feature #139

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Changelog feature #139

merged 12 commits into from
Jan 12, 2024

Conversation

cnivolle
Copy link
Member

Checklist

  • My PR is related to an opened issue : No.

⚠️ If changes affect GitHub Action files

  • I have added tests to cover my changes : link

Pull request type

Feature addition: a changeling.

Please check the type of change your PR introduces:

  • Documentation content changes
  • Bugfix on the site
  • Build related changes
  • Other (please describe): new feature

Description

This add a first iteration on the changelog. A documentation is missing for further iterations.

A summary of the changes

Why is this needed?

Reviewes

@juliamrch

Copy link

Deployment has finished 👁️👄👁️ Your app is available here

Copy link

🚀 Your app has been updated and is available here

@waxzce
Copy link
Member

waxzce commented Jan 12, 2024

I think we nedd full date writen somewhere

@StevenLeRoux
Copy link

Not very fond of the clicky readability (you have to click, open the page, then come back or navigate into the changelog entry . I'd prefer a flattened version with all the content readable in a glinch

Copy link

🚀 Your app has been updated and is available here

@cnivolle cnivolle self-assigned this Jan 12, 2024
Copy link

🚀 Your app has been updated and is available here

@juliamrch
Copy link
Collaborator

I think we nedd full date writen somewhere

Noted and added: http://clever-doc-review-changelog-feature-pr-139.cleverapps.io/changelog/

@juliamrch juliamrch self-requested a review January 12, 2024 17:47
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes and internal feedback have been implemented, all good.

@juliamrch juliamrch merged commit e17ef0b into CleverCloud:main Jan 12, 2024
3 checks passed
Copy link

Your review app has been deleted 👋

juliamrch pushed a commit that referenced this pull request Jan 22, 2024
* feat: added the changelog theme and conf

* docs,ui: css update and previous changelog content

* ui: pagination for 50 items

* ui: list changelog styling

* docs: changelog content update

* ui: breadcrumbs get standard link color

* ui: list get better date format and layout.

* docs: added a changelog section to the readme

* ui: date is easier to read in changelog posts

* ui: Feed button is easier to see

* docs: changelog content update

* fix: link color in changelog light theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants