Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newrelic browser monitoring warn #181

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Newrelic browser monitoring warn #181

merged 4 commits into from
Feb 15, 2024

Conversation

cnivolle
Copy link
Member

@cnivolle cnivolle commented Feb 5, 2024 •
edited
Loading

Checklist

Pull request type

Doc update.

Please check the type of change your PR introduces:

  • Documentation content changes
  • Bugfix on the site
  • Build related changes
  • Other (please describe):

Description

Adding a callout to warn about New Relic's auto-insertion of JavaScript, and explain how to disable it.

Why is this needed?

An issue was opened: #10.

Reviewes

Who should review these changes? @juliamrch

@cnivolle cnivolle requested a review from juliamrch February 5, 2024 13:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024

Deployment has finished 👁️👄👁️ Your app is available here

juliamrch
juliamrch previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the link color after merging.

assets/css/custom.css Show resolved Hide resolved
@juliamrch juliamrch added the documentation Improvements or additions to documentation label Feb 5, 2024
@juliamrch
Enforce link color in shortcodes
ea7f33f 
Links in light mode are showed in a different color than the rest of the doc. Added their reference in css after inspecting the element in web browser.
@juliamrch
Copy link
Collaborator

juliamrch commented Feb 5, 2024 •
edited
Loading

Last commit containing css update has been successfully deployed on Clever Cloud but for some reason the job is showing a timeout.
Capture d’écran 2024-02-05 à 17 03 36

@cnivolle you can check the update and the preview here and if everything is fine, you're free to merge ✌️

@juliamrch juliamrch assigned juliamrch and cnivolle and unassigned juliamrch Feb 7, 2024
@juliamrch juliamrch added the bug Something isn't working label Feb 7, 2024
@juliamrch juliamrch added this to the Clear previous doc issues milestone Feb 7, 2024
@juliamrch juliamrch added the waiting Waiting from fixes or tests by submitter label Feb 7, 2024
@cnivolle
Copy link
Member Author

cnivolle commented Feb 7, 2024

@juliamrch That's perfect.

@cnivolle cnivolle requested a review from juliamrch February 8, 2024 13:30
cnivolle
cnivolle commented Feb 12, 2024
View reviewed changes
Copy link
Member Author

@cnivolle cnivolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.

juliamrch
juliamrch previously approved these changes Feb 12, 2024
View reviewed changes
content/doc/metrics/new-relic.md Outdated Show resolved Hide resolved
cnivolle
cnivolle commented Feb 12, 2024
View reviewed changes
Copy link
Member Author

@cnivolle cnivolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is all good.

@cnivolle cnivolle requested a review from juliamrch February 12, 2024 10:53
@github-actions GitHub Actions
Copy link

🚀 Your app has been updated and is available here

@juliamrch juliamrch merged commit 39b0543 into CleverCloud:main Feb 15, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

Your review app has been deleted 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliamrch juliamrch juliamrch approved these changes

Assignees

@cnivolle cnivolle

Labels
bug Something isn't working documentation Improvements or additions to documentation waiting Waiting from fixes or tests by submitter
Projects
Documentation updates
Status: Done
Milestone
Clear previous doc issues
Development

Successfully merging this pull request may close these issues.
2 participants
@cnivolle @juliamrch