Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct docker command #199

Merged
merged 1 commit into from
Feb 23, 2024
Merged

correct docker command #199

merged 1 commit into from
Feb 23, 2024

Conversation

dgoosens
Copy link
Contributor

@dgoosens dgoosens commented Feb 21, 2024

correct docker command with full image name

Describe your PR

full docker name of the docker run command, ie clevercloud/clever-tools (vendor/image-name)
running the command with just the image name will not work

Checklist

Reviewes

Who should review these changes? @

correct docker command with full image name
Copy link

Deployment has finished 👁️👄👁️ Your app is available here

@juliamrch
Copy link
Collaborator

juliamrch commented Feb 22, 2024

No description 💔?

Why is wasn't working? etc

@juliamrch juliamrch added the waiting Waiting from fixes or tests by submitter label Feb 22, 2024
@dgoosens
Copy link
Contributor Author

hello @juliamrch

sorry... forgot...
I updated the PR

Dmitri

Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and the fix is correct.

Nice catch @dgoosens, your contribution is highly appreciated!

@juliamrch juliamrch added documentation Improvements or additions to documentation and removed waiting Waiting from fixes or tests by submitter labels Feb 23, 2024
@juliamrch juliamrch merged commit f0138bf into CleverCloud:main Feb 23, 2024
4 checks passed
Copy link

Your review app has been deleted 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants