Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changelog: images update part2 #210

Merged
merged 2 commits into from
Mar 28, 2024
Merged

changelog: images update part2 #210

merged 2 commits into from
Mar 28, 2024

Conversation

davlgd
Copy link
Collaborator

@davlgd davlgd commented Feb 27, 2024

Describe your PR

I've added an entry to the new images update and changed default version supported by .Net in documentation at the same time.

@github-actions GitHub Actions
Copy link

Deployment has finished 👁️👄👁️ Your app is available here

cnivolle
cnivolle previously approved these changes Feb 27, 2024
View reviewed changes
juliamrch
juliamrch requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, added some suggestions to clarify what ad who performs the action (runtime, Clever Cloud). Feel free to suggest other versions.

content/changelog/2024-02-27-images-update-part2.md Outdated Show resolved Hide resolved
static/partials/language-specific-deploy/dotnet.md Outdated Show resolved Hide resolved
static/partials/language-specific-deploy/dotnet.md Outdated Show resolved Hide resolved
@davlgd davlgd force-pushed the davlgd-changelog-images-update-270202 branch from f84af8e to e37dab1 Compare February 27, 2024 15:39
@github-actions GitHub Actions
Copy link

🚀 Your app has been updated and is available here

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 Your app has been updated and is available here

juliamrch
juliamrch previously approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan of the stay tuned with the RSS link. Let's merge.

@davlgd
Copy link
Collaborator Author

davlgd commented Feb 27, 2024

Big fan of the stay tuned with the RSS link. Let's merge.

We need to wait @s0dyy review before merging

@juliamrch
Copy link
Collaborator

waiting for @s0dyy to have a look before merging.

@juliamrch juliamrch added the waiting Waiting from fixes or tests by submitter label Mar 11, 2024
@juliamrch
Copy link
Collaborator

juliamrch commented Mar 22, 2024 •
edited
Loading

Hi @davlgd the static/partials/language-specific-deploy/dotnet.md file doesn't exist anymore in the codebase, I think you can resolve conflicts by simply adding the content you modified to content/doc/applications/dotnet/_index.md.

You can also resolve the conversations if we agree they have been solved or if you want to modify something based on the comments. Up to you 💪!

@davlgd davlgd force-pushed the davlgd-changelog-images-update-270202 branch from e37dab1 to 7bddeb2 Compare March 28, 2024 06:21
@davlgd
Copy link
Collaborator Author

davlgd commented Mar 28, 2024

LGTM

@davlgd davlgd requested review from juliamrch and cnivolle March 28, 2024 06:22
@github-actions GitHub Actions
Copy link

🚀 Your app has been updated and is available here

@davlgd davlgd force-pushed the davlgd-changelog-images-update-270202 branch from 7bddeb2 to 4eab1c2 Compare March 28, 2024 06:25
@github-actions GitHub Actions
Copy link

🚀 Your app has been updated and is available here

juliamrch
juliamrch approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@juliamrch juliamrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts seem resolved. Nice update. Good to go imo

@juliamrch juliamrch merged commit d6b748f into main Mar 28, 2024
5 checks passed
@juliamrch juliamrch deleted the davlgd-changelog-images-update-270202 branch March 28, 2024 10:31
@github-actions GitHub Actions
Copy link

Your review app has been deleted 👋

cnivolle pushed a commit to cnivolle/documentation that referenced this pull request Jul 29, 2024
@davlgd @juliamrch @cnivolle
changelog: images update part2 (CleverCloud#210)
b08676f 
* changelog: Images update part 2

* docs: update .Net versions

Co-Authored-By: Julia March <[email protected]>

---------

Co-authored-by: Julia March <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0dyy s0dyy s0dyy left review comments

@juliamrch juliamrch juliamrch approved these changes

@cnivolle cnivolle Awaiting requested review from cnivolle

Assignees

@davlgd davlgd

Labels
changelog waiting Waiting from fixes or tests by submitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davlgd @juliamrch @cnivolle @s0dyy