Logging improvements #3803
Draft
Logging improvements #3803
+106
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cib_file_read_and_verify() can return other errors than were being caught.
Previously, terminate_cib() would log an info message, and most callers would log additional, partially redundant messages. Now, log at the callers (who have better context), and don't log in terminate_cib(). Also, improve the wording of the messages, and drop the no longer necessary caller argument to terminate_cib().
Avoid logging XML (especially at notice level), instead picking out the interesting attributes. Previously, the message was at debug level (instead of notice) if the DC's CIB was used, but I think it makes sense to always log at notice for troubleshooting purposes.
Previously, the controller could create a dot file of its FSA transitions -- as trace log messages. Someone would have to copy and paste the relevant portion of each trace log into a file to use it. Stop the insanity now.
... and de-functionize crmd_init(). crmd_fast_exit() -> crm_exit() already logs an exit message, so we don't need a separate one here.
Don't log that we're requesting execution if we're not, and make the go/no-go logs more consistent. Also, drop a redundant log for local execution in execute_rsc_action().
|
This is not final and needs testing. A long lab had problems. But if anyone wants to pick it up and finish it, they're welcome to it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.