Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket: 🔧 Migrating the Socket Module from Java to Kotlin #211

Merged
merged 22 commits into from
Dec 26, 2024

Conversation

psychology50
Copy link
Member

@psychology50 psychology50 commented Dec 25, 2024

작업 이유

I have been working on partially migrating the Socket Module from Java to Kotlin.
This migration was initiated to take advantage of Kotlin's features, which I believe will be particularly beneficial for handling real-time connections in the socket module.


작업 사항

  • Partially converted Java code to Kotlin to improve code stability and readability.
  • Enhanced authentication/authorization result processing by introducing the EvaluationResult sealed interface in the PreAuthorizeSpELParser.
  • Applied functional programming principles to make the code flow more explicit.
  • Leveraged Kotlin's null safety to eliminate potential NullPointerException issues.

리뷰어가 중점적으로 확인해야 하는 부분

  • Ensure interoperability between Java and Kotlin is well-maintained.
  • Verify that Kotlin-specific features (e.g., sealed interfaces, extension functions) are used appropriately.
  • Check that existing functionality continues to work as expected.
  • Review error handling and logging to ensure they are implemented properly.
  • Confirm that the code style aligns with the project's standards.

발견한 이슈

  • none

@psychology50 psychology50 added the refactoring 리팩토링 작업 label Dec 25, 2024
@psychology50 psychology50 self-assigned this Dec 25, 2024
@psychology50 psychology50 merged commit 30524c5 into dev Dec 26, 2024
1 check passed
@psychology50 psychology50 deleted the fix/socket-module-migration-to-kotlin branch December 26, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring 리팩토링 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant