Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: added jsdialog test #10767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpranam
Copy link
Member

@lpranam lpranam commented Dec 18, 2024

test for fix from 296d48f

Change-Id: I7033cf78a25235863662da6687107b6a539c2232

  • Target version: master

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@lpranam lpranam requested a review from eszkadev December 18, 2024 23:31
@eszkadev
Copy link
Contributor

valid cypress fail:

 1) JSDialog unit test
       JSDialog check data validity options:
     CypressError: Timed out retrying after 10050ms: `cy.select()` failed because this element:

`<select class="jsdialog ui-listbox " id="allow-input" accesskey="A">...</select>`

is being covered by another element:

`<div class="jsdialog-overlay dimmed" id="modal-dialog-cool_alert-overlay">...</div>`

@lpranam
Copy link
Member Author

lpranam commented Dec 25, 2024

requires https://gerrit.libreoffice.org/c/core/+/179402 to pass the test.

test for fix from 296d48f

Signed-off-by: Pranam Lashkari <[email protected]>
Change-Id: I7033cf78a25235863662da6687107b6a539c2232
@eszkadev
Copy link
Contributor

eszkadev commented Jan 9, 2025

it requires some conversion to async, right?
https://gerrit.libreoffice.org/c/core/+/179509
https://gerrit.libreoffice.org/c/core/+/179402

@eszkadev eszkadev added the draft label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

2 participants