Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refocus comment when needed automatically #10800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpranam
Copy link
Member

@lpranam lpranam commented Dec 24, 2024

  • Target version: master

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@lpranam lpranam force-pushed the comment_focus branch 3 times, most recently from 88ba3d3 to bfe67b0 Compare December 25, 2024 13:49
@lpranam lpranam requested a review from gokaysatir December 31, 2024 15:31
Copy link
Contributor

@gokaysatir gokaysatir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we need to set "needFocus" to null in more placees. But i couldn't find an edge case. This is a useful feature, thanks for the improvements.

problem:
if user was editing comment and switched tab/window,
on returning to tab document will gain focus instead of comment
and user accidentally type in doc instead of comment

Signed-off-by: Pranam Lashkari <[email protected]>
Change-Id: I356f311461010fc191620ac489f6b3bc65434e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Test
Development

Successfully merging this pull request may close these issues.

2 participants