tf: Scope model under a model identifier (WIP) #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So what I want to be able to do is:
This does not work right now as there are collisions between variable names in the TF symbolic graph. This first commit is – I think – a right step towards fixing this, but is not enough: I think in the
model.py
file, where we rely on thetf.nn.seq2seq.embedding_rnn_seq2seq
implementation, something must not be properly scoped.What do you guys think?