Extension of PoolCurrentPaydayInfo/PoolInfoResponse

[drsk0]

Purpose

Add suspension info to PoolCurrentPaydayInfo / PoolInfoResponse. This depends on Concordium/concordium-grpc-api#74.

Changes

See above.

Checklist

• My code follows the style of this project.
• The code compiles without warnings.
• I have performed a self-review of the changes.
• I have documented my code, in particular the intent of the
  hard-to-understand areas.
• (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

• link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf

• I accept the above linked CLA.

[td202]

It might be worth making a explicit ToJSON/FromJSON instances for CurrentPaydayBakerPoolStatus to be consistent in how Nothing values are represented. Currently, isPrimedForSuspension and missedRounds are represented as null values if Nothing, while isSuspended is just not present if it's Nothing.

Current output of GetPoolStatus:

{
    "allPoolTotalCapital": "57662194352796877",
    "bakerAddress": "48XGRnvQoG92T1AwETvW5pnJ1aRSPMKsWtGdKhTqyiNZzMk3Qn",
    "bakerEquityCapital": "6621352845013062",
    "bakerId": 0,
    "bakerStakePendingChange": {
        "pendingChangeType": "NoChange"
    },
    "currentPaydayStatus": {
        "bakerEquityCapital": "6620269533524289",
        "blocksBaked": 2740,
        "commissionRates": {
            "bakingCommission": 0.1,
            "finalizationCommission": 1.0,
            "transactionCommission": 0.1
        },
        "delegatedCapital": "0",
        "effectiveStake": "2882948611945322",
        "finalizationLive": true,
        "isPrimedForSuspension": null,
        "lotteryPower": 9.978157861545638e-2,
        "missedRounds": null,
        "transactionFeesEarned": "188108074"
    },
    "delegatedCapital": "0",
    "delegatedCapitalCap": "0",
    "poolInfo": {
        "commissionRates": {
            "bakingCommission": 0.1,
            "finalizationCommission": 1.0,
            "transactionCommission": 0.1
        },
        "metadataUrl": "",
        "openStatus": "closedForAll"
    },
    "poolType": "BakerPool"
}

[drsk0]

@td202 So we would also change how other optional values are represented in BakerPoolStatus, like activeStatusFields?

[td202]

@td202 So we would also change how other optional values are represented in BakerPoolStatus, like activeStatusFields?

No, I don't think we should change BakerPoolStatus. I just mean that instead of isPrimedForSuspension and missedRounds being null if they're Nothing, they should just not be present in the JSON object (as is the case in BakerPoolStatus).

[drsk0]

I see, I added omitNothingFields = True in the defaultOptions of the deriveJSON slice for CurrentPaydayBakerPoolStatus, this will have the desired effect.