Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move isSuspended from BakerPoolStatus to ActiveBakerPoolStatus. #590

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 10, 2025

Purpose

Relates to: Concordium/concordium-node#1309
Depends on: Concordium/concordium-grpc-api#76

This is intended to address the correct presentation of the suspended status of a validator pool: a validator pool's suspended status should be based on the suspended status on the pool owner's account.

Changes

  • Add abpsIsSuspended to ActiveBakerPoolStatus.
  • Remove psIsSuspended from BakerPoolStatus. This change should not affect the JSON serialization of BakerPoolStatus.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link
Contributor

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. @td202 Could you explain, how this fixes Concordium/concordium-node#1309, as it's not really clear to me.

@td202
Copy link
Contributor Author

td202 commented Jan 14, 2025

The changes look good. @td202 Could you explain, how this fixes Concordium/concordium-node#1309, as it's not really clear to me.

The fix is mainly in the related node PR: https://github.com/Concordium/concordium-node/pull/1310/files
Essentially, we get the suspended status from the "active baker", i.e. the record on the account, rather than from the state in the current epoch committee.

@td202 td202 merged commit 65b2fea into main Jan 14, 2025
40 checks passed
@td202 td202 deleted the suspended-pool branch January 14, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants