-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI error handling #93
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from limemloh
January 26, 2024 12:06
Hi @limemloh I have made this PR with better error mapping of FFI errors. I’m not sure the interface given to developers are 100 %, so can you give it a review and then we can have a discussion if we can make some improvements. |
This reverts commit ee7563c.
ghost
mentioned this pull request
Jan 29, 2024
limemloh
reviewed
Jan 29, 2024
ghost
requested a review
from limemloh
January 30, 2024 08:54
limemloh
approved these changes
Jan 30, 2024
ghost
deleted the
better-ffi-error-handling
branch
January 30, 2024 09:09
ghost
mentioned this pull request
Jan 30, 2024
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Returns result with possible error codes from FFI calls.
Changes
Checklist
hard-to-understand areas.