Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the computation of missed rounds on timeout. #1307

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Jan 10, 2025

Purpose

Closes #1308

Fix the computation of missed rounds on timeout.

Changes

  • Revise computeMissedRounds to use the QC and TC of a block to compute the missed rounds. The missed rounds will be from qcRound + 1 to tcRound (inclusive) if the TC is present. (No missed rounds if the TC is absent.)

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@td202 td202 requested review from drsk0 and eb-concordium January 10, 2025 13:55
Copy link
Contributor

@eb-concordium eb-concordium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@td202 td202 merged commit 7a820d3 into main Jan 10, 2025
3 checks passed
@td202 td202 deleted the fix-compute-missed-rounds branch January 10, 2025 15:40
Copy link
Contributor

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition of missed rounds makes sense to me. @td202 what's the reasoning, that there are no other timeout certificates between the round of the QC and the observed TC?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Missed rounds are computed incorrectly
3 participants