fix: Unused Declaration for Array Columns (define.go)
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the second half of this issue, by allowing array columns to be marked as used when they are, in fact used.
In some cases, resolution is performed using a path. The fix thus far did not properly account for this.
This puts in place a fix for converting a `Handle` into a `String` for use with `resolve_symbol_by_path()`. Specifically, there seems to be a difference in the handling of the top-level module (a.k.a the `<prelude>`).
delehef
reviewed
Jun 14, 2024
| @@ -55,6 +55,24 @@ impl Handle { | |||
| } | |||
| } | |||
|
|
|||
| pub fn to_string(&self) -> String { | |||
| // NOTE: its unclear why a distinction is needed for the | |||
| // prelude. | |||
There was a problem hiding this comment.
Because you want to display top-level symboles as X, not as <prelude>.X (which is surprising to the user).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts through a fix for the generated
define.gowhere certain unused columns were being turned into Go declarations. Since these declarations were not then being used, Go was reporting an error (since it is very strict about this).