XXX: add prints at critical steps

Consensys · Nov 9, 2023 · 4e6454d · 4e6454d
1 parent 131fbb5
commit 4e6454d
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/backend/plonk/bls12-377/verify.go b/backend/plonk/bls12-377/verify.go
diff --git a/std/algebra/native/sw_bls12377/pairing2.go b/std/algebra/native/sw_bls12377/pairing2.go
@@ -126,6 +126,10 @@ func (c *Curve) MultiScalarMul(P []*G1Affine, scalars []*Scalar) (*G1Affine, err
 	res := c.ScalarMul(P[0], scalars[0])
 	for i := 1; i < len(P); i++ {
 		q := c.ScalarMul(P[i], scalars[i])
+		c.api.Println(i)
+		c.Print(*P[i])
+		c.Print(*q)
+		c.Print(*res)
 		res = c.Add(res, q)
 	}
 	return res, nil

diff --git a/std/recursion/plonk/verifier.go b/std/recursion/plonk/verifier.go
@@ -514,10 +514,16 @@ func (v *Verifier[FR, G1El, G2El, GtEl]) AssertProof(vk VerifyingKey[FR, G1El, G
 		_s1, _s2, // second & third part
 	)
 
+	// for i := range points {
+	// 	v.curve.Print(*points[i])
+	// 	v.f.Println(scalars[i])
+	// }
 	linearizedPolynomialDigest, err := v.curve.MultiScalarMul(points, scalars)
 	if err != nil {
 		return fmt.Errorf("linearized polynomial digest MSM: %w", err)
 	}
+	// XXX: it looks like in MultiScalarMul when we compute 1*0 then it messes up!
+	v.curve.Print(*linearizedPolynomialDigest) // wrong
 
 	// Fold the first proof
 	digestsToFold := []kzg.Commitment[G1El]{
@@ -530,6 +536,7 @@ func (v *Verifier[FR, G1El, G2El, GtEl]) AssertProof(vk VerifyingKey[FR, G1El, G
 		vk.S[1],
 	}
 	digestsToFold = append(digestsToFold, vk.Qcp...)
+	// v.curve.Print(digestsToFold[1].G1El) // wrong
 	foldedProof, foldedDigest, err := v.kzg.FoldProof(
 		digestsToFold,
 		proof.BatchedProof,
@@ -540,6 +547,8 @@ func (v *Verifier[FR, G1El, G2El, GtEl]) AssertProof(vk VerifyingKey[FR, G1El, G
 		return fmt.Errorf("fold kzg proof: %w", err)
 	}
 	shiftedZeta := v.f.Mul(zeta, &vk.Generator)
+	// v.curve.Print(foldedDigest.G1El)       // wrong
+	// v.f.Println(&foldedProof.ClaimedValue) // wrong
 	err = v.kzg.BatchVerifyMultiPoints(
 		[]kzg.Commitment[G1El]{
 			foldedDigest,

diff --git a/std/recursion/plonk/verifier_test.go b/std/recursion/plonk/verifier_test.go
@@ -63,7 +63,8 @@ func getInner(assert *test.Assert, field, outer *big.Int) (constraint.Constraint
 		backend.WithVerifierChallengeHashFunction(fsVerifierHasher),
 		backend.WithVerifierKZGFoldingHashFunction(kzgProverHasher),
 	)
-	assert.NoError(err)
+	// commented out to allow debugging native and circuit verifier
+	// assert.NoError(err)
 	return innerCcs, innerVK, innerPubWitness, innerProof
 }