Feat/blockdata unique gas limit constant #1699
Open
+67
−40,549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amkCha
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
3 times, most recently
from
41fd16c to
0527728
Compare
OlivierBBB
reviewed
Jan 14, 2025
|
|
||
| // row i + 1 | ||
| // comparison to maximum | ||
| wcpCallToLEQ(1, data, EWord.of(Bytes.ofUnsignedLong(LINEA_GAS_LIMIT_MAXIMUM))); | ||
| wcpCallToLEQ(1, data, EWord.of(Bytes.ofUnsignedLong(GAS_LIMIT_MAXIMUM))); |
DavePearce
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
from
5e6f964 to
b507971
Compare
DavePearce
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
from
b507971 to
0a8da2e
Compare
This ensures that, when running `gradle build`, it also arises the `buildTracer` is run beforehand. This is necessary to ensure that all `Trace.java` files (and related) are generated.
This attempts to force the `Trace.java` files to be built before anything else important happens.
This configures the build process to be conditional on a system-wide property called "blockchain". This property can be specified on the command-line with e.g. "-Dblockchain=Ethereum" to set the target chain to Ethereum. By default, the blockchain is assumed to be Linea. Therefore, its only when running the reference tests that this property needs to be set. Furthermore, if the reference tests are run without setting this property ... then an error is reported and the build fails.
DavePearce
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
from
0a8da2e to
33f92a7
Compare
DavePearce
reviewed
Jan 14, 2025
| @@ -60,7 +57,7 @@ public class BlockdataOperation extends ModuleOperation { | |||
|
|
|||
| private final boolean firstBlockInConflation; | |||
| private final int ctMax; | |||
| @EqualsAndHashCode.Include @Getter private final OpCode opCode; | |||
There was a problem hiding this comment.
This change looks odd, and potentially unexpected. Is there a specific reason we wanted to remove this?
There was a problem hiding this comment.
I don't see that on my local branch
But it's strange that there should be an @EqualsAndHashCode.Include in the first place. We don't need to compare BlockdataOperation. And if we did we would have to include some extra identifier (e.g. the blockHeader)
There was a problem hiding this comment.
Ok, well if you believe that's safe ... then I'm happy to merge.
There was a problem hiding this comment.
Yes, it's a copy paste to get the OpCode type that I got from another file. I forgot to remove the annotations, I don't see the need there
DavePearce
approved these changes
Jan 15, 2025
amkCha
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
from
33f92a7 to
2517114
Compare
DavePearce
force-pushed
the
feat/blockdata-unique-gas-limit-constant
branch
from
9b857ea to
33f92a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate trace files on tests launch to dynamically account for a different Min and Max gas limit between Ethereum and Linea
With Ethereum Gas limits
StateRefTests
BlockchainRefTests
With Linea Gas limits
FastReplayTests
Unit tests