use a single blob service #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid memory leak due to cleanup thread started by each TempFileFactory instance it would be preferable to use com.coremedia.cms.common.plugins.beans_for_plugins2.CommonBeansForPluginsConfiguration and not to create a fallback blob service, but that's currently prevented by com.coremedia.contenthub.api.BaseFileSystemConfiguration
JensDallmann
approved these changes
Oct 2, 2024
henningSaulCM
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid memory leak due to cleanup thread started by each TempFileFactory instance
it would be preferable to use com.coremedia.cms.common.plugins.beans_for_plugins2.CommonBeansForPluginsConfiguration and not to create a fallback blob service, but that's currently prevented by
com.coremedia.contenthub.api.BaseFileSystemConfiguration(see https://coremediagmbh.atlassian.net/browse/CMS-25756). This temporary fix relies on the private API dependencycom.coremedia.cms.common.plugins.beans_for_plugins_container.CommonBeansForPluginsContainerFound this while working on https://coremedia.zendesk.com/agent/tickets/87572 and looking at https://coremedia.zendesk.com/agent/tickets/79089
The very same problem exists in other content hub adapter implementations as well:
Note: I didn't test this fix, but it's definitely not a good idea to create temporary TempFileFactory instances.