fix memory leak in AudioFormatInputSource

CrSjimo · Jan 21, 2024 · 421959e · 421959e
1 parent 2735138
commit 421959e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/format/AudioFormatInputSource.cpp b/src/format/AudioFormatInputSource.cpp
@@ -123,8 +123,8 @@ namespace talcs {
             return false;
         if (d->io->open(QIODevice::ReadOnly)) {
             d->ratio = sampleRate / d->io->sampleRate();
-            d->resampler = new AudioFormatInputSourcePrivate::AudioFormatInputResampler(d->ratio, bufferSize,
-                                                                                        d->io->channelCount(), d);
+            d->resampler.reset(new AudioFormatInputSourcePrivate::AudioFormatInputResampler(d->ratio, bufferSize,
+                                                                                        d->io->channelCount(), d));
             d->io->seek(outPositionToIn(d->position, d->ratio));
             return AudioStreamBase::open(bufferSize, sampleRate);
         } else
@@ -138,8 +138,7 @@ namespace talcs {
             return;
         d->io->close();
         d->ratio = 0;
-        delete d->resampler;
-        d->resampler = nullptr;
+        d->resampler.reset();
     }
 
     /**

diff --git a/src/format/AudioFormatInputSource_p.h b/src/format/AudioFormatInputSource_p.h
@@ -46,7 +46,7 @@ namespace talcs {
             QVector<float> tmpBuf;
         };
 
-        AudioFormatInputResampler *resampler = nullptr;
+        QScopedPointer<AudioFormatInputResampler> resampler;
 
         qint64 inPosition = 0;