fixing old embroiderer packages, working on implementing internationa…

…l number formatting
CrowdStrike · Jan 18, 2025 · a12a7b7 · a12a7b7
1 parent c738342
commit a12a7b7
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 16 deletions.
diff --git a/packages/ember-headless-form/package.json b/packages/ember-headless-form/package.json
@@ -33,6 +33,7 @@
     "babel-eslint": "^10.1.0",
     "ember-async-data": "^1.0.3",
     "ember-modifier": "^4.1.0",
+    "intl-number-parser": "^1.0.5",
     "tracked-built-ins": "^3.1.0"
   },
   "peerDependencies": {

diff --git a/packages/ember-headless-form/src/-private/components/control/input.gts b/packages/ember-headless-form/src/-private/components/control/input.gts
@@ -50,6 +50,14 @@ export interface HeadlessFormControlInputComponentSignature {
      */
     type?: InputType;
 
+    /**
+     * Some inputs are specific to locales, like numbers. This
+     *
+     *
+     *
+     */
+    locale?: string
+
     // the following are private arguments curried by the component helper, so users will never have to use those
 
     /*
@@ -106,10 +114,18 @@ export default class HeadlessFormControlInputComponent extends Component<Headles
   @action
   handleInput(e: Event | InputEvent): void {
     assert('Expected HTMLInputElement', e.target instanceof HTMLInputElement);
-    this.args.setValue(
-      this.type === 'number' ? parseFloat(e.target.value) : e.target.value
-    );
+    this.args.setValue(e.target.value);
   }
+
+  @action
+  handleUnfocus(e: Event | InputEvent): void {
+    assert('Expected HTMLInputElement', e.target instanceof HTMLInputElement);
+
+    if(this.type === "number"){
+      this.args.setValue(parseFloat(e.target.value));
+    }
+  }
+
   <template>
     <input
       name={{@name}}
@@ -120,6 +136,7 @@ export default class HeadlessFormControlInputComponent extends Component<Headles
       aria-describedby={{if @invalid @errorId}}
       ...attributes
       {{on "input" this.handleInput}}
+      {{on "focusout" this.handleUnfocus}}
     />
   </template>
 }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test-app/app/templates/index.hbs b/test-app/app/templates/index.hbs
@@ -23,13 +23,24 @@
     <div class='my-2 flex flex-col'>
       <field.Label class={{if field.isInvalid 'text-red-500'}}>Last name</field.Label>
       <field.Input
+        @max="10"
         class='border rounded px-2 {{if field.isInvalid "border-red-500"}}'
         required
       />
       <field.Errors class='text-red-600' />
     </div>
   </form.Field>
-
+  <form.Field @name="rating" as |field|>
+    <div class="my-2 flex flex-col">
+      <field.Label class={{if field.isInvalid 'text-red-500'}}>How likely are you to recommend us?</field.Label>
+      <field.Input
+        @type="number"
+        min="1"
+        max="10"
+        class="border rounded px-2 {{if field.isInvalid "border-red-500"}}"
+      />
+    </div>
+  </form.Field>
   <form.Field @name='gender' as |field|>
     <field.RadioGroup class='my-2 flex flex-col' as |group|>
       <group.Label>Gender</group.Label>

diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js
@@ -54,10 +54,9 @@ module.exports = async function () {
         npm: {
           devDependencies: {
             'ember-source': '~4.8.0',
-            // @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383
-            '@embroider/core': '2.1.2-unstable.3a9d8ad',
-            '@embroider/compat': '2.1.2-unstable.3a9d8ad',
-            '@embroider/webpack': '2.1.2-unstable.3a9d8ad',
+            '@embroider/core': '3.5.0',
+            '@embroider/compat': '3.8.0',
+            '@embroider/webpack': '4.0.9',
           },
         },
       }),
@@ -66,10 +65,9 @@ module.exports = async function () {
         npm: {
           devDependencies: {
             'ember-source': '~4.8.0',
-            // @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383
-            '@embroider/core': '2.1.2-unstable.3a9d8ad',
-            '@embroider/compat': '2.1.2-unstable.3a9d8ad',
-            '@embroider/webpack': '2.1.2-unstable.3a9d8ad',
+            '@embroider/core': '3.5.0',
+            '@embroider/compat': '3.8.0',
+            '@embroider/webpack': '4.0.9',
           },
         },
       }),
@@ -78,10 +76,9 @@ module.exports = async function () {
         npm: {
           devDependencies: {
             'ember-source': releaseVersion,
-            // @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383
-            '@embroider/core': '2.1.2-unstable.3a9d8ad',
-            '@embroider/compat': '2.1.2-unstable.3a9d8ad',
-            '@embroider/webpack': '2.1.2-unstable.3a9d8ad',
+            '@embroider/core': '3.5.0',
+            '@embroider/compat': '3.8.0',
+            '@embroider/webpack': '4.0.9',
           },
         },
       }),