Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2180 change sorting of language dropdown menu on homepage #149

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Nov 13, 2023

Description

https://jira.cru.org/secure/RapidBoard.jspa?rapidView=150&view=detail&selectedIssue=GT-2180
Currently the language menu on the homepage of knowgod.com sorts across the columns going left -> right and then down to the next row.
We'd like to match the way the language menu appears while you're in a tool so that it sorts going down a column, then down the next column, etc.

Changes I made

  • Changed flexbox divs to a ul so that it would sort down the column before rows.
  • The number of columns changes based on screen size
  • Changed CSS to make li items look the same as the divs

@caleballdrin caleballdrin self-assigned this Nov 13, 2023
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added one comment about making the modal more center-aligned on larger screens. I know that's not something you did, but it's a easy fix, so wondered if you could throw that into this PR. I added the styles needed on a comment.

src/app/header/header.component.css Show resolved Hide resolved
@caleballdrin caleballdrin requested a review from dr-bizz November 13, 2023 19:54
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@caleballdrin caleballdrin merged commit 0550fec into master Nov 14, 2023
2 checks passed
@caleballdrin caleballdrin deleted the lang-sort branch November 14, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants