GT-2095 - Support creating & managing collections Tool Groups #695

dr-bizz · 2023-10-23T17:40:18Z

Description

https://jira.cru.org/browse/GT-2095
Create ToolGroup functionality, so the admin can create Tool groups, assign countries, Languages and Praxis to them and then create relationships between ToolGroups and Tools.

Changes

Created a new Tool Groups page
Using npm package countries-list to get Countries names and ISO code
Loading in Tool Groups effectively by only loading data which is necessary at that time.
Created reusable inputs to make development easier.
Created a component which handles Country, Language and Praxis rules.
Created component to handle Tools
Create / edit Tool Groups
Created Langauge BCP47 service
Created Tool Group service to handle all Tool Group communication to server
Updated TS to compile to ES 2017

codecov · 2023-10-23T19:10:37Z

Codecov Report

Attention: Patch coverage is 81.84615% with 118 lines in your changes are missing coverage. Please review.

Project coverage is 70.79%. Comparing base (de55548) to head (b687374).

❗ Current head b687374 differs from pull request most recent head 3255402. Consider uploading reports for the commit 3255402 to get more accurate results

Files	Patch %	Lines
...t-tool-group/abstract-edit-tool-group.component.ts	53.84%	26 Missing and 4 partials ⚠️
...p/update-tool-group/update-tool-group.component.ts	73.19%	10 Missing and 16 partials ⚠️
...e-reuseable/tool-group-rule-reuseable.component.ts	79.72%	10 Missing and 5 partials ⚠️
...l-reuseable/tool-group-tool-reuseable.component.ts	57.69%	10 Missing and 1 partial ⚠️
.../edit-tool-group-rule/tool-group-rule.component.ts	82.75%	8 Missing and 2 partials ⚠️
...ol-group-resource/tool-group-resource.component.ts	90.14%	5 Missing and 2 partials ⚠️
.../app/components/tool-group/tool-group.component.ts	92.50%	2 Missing and 4 partials ⚠️
...pp/components/tool-groups/tool-groups.component.ts	82.35%	6 Missing ⚠️
src/app/service/tool-group/tool-group.service.ts	93.90%	2 Missing and 3 partials ⚠️
...p/create-tool-group/create-tool-group.component.ts	94.28%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   65.77%   70.79%   +5.01%     
==========================================
  Files          60       71      +11     
  Lines        1607     2061     +454     
  Branches      133      186      +53     
==========================================
+ Hits         1057     1459     +402     
- Misses        524      551      +27     
- Partials       26       51      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stage-branch-merger · 2023-10-23T19:13:32Z

I see you added the "On Staging" label, I'll get this merged to the staging branch!

frett · 2023-10-24T21:27:03Z

Suggestion Weight should be a float and not a boolean.

src/app/service/tool-group/tool-group.service.ts

src/app/service/languages-bcp47-tag.service.ts

src/app/components/edit-tool-group-tool-reuseable/tool-group-tool-reuseable.component.html

dr-bizz · 2023-10-25T15:04:59Z

I'm unsure how I made Suggestion Weight a boolean, I must have been on auto pilot and skimmed over it

src/app/components/edit-tool-group-resource/tool-group-resource.component.html

src/app/components/edit-tool-group-resource/tool-group-resource.component.ts

src/app/service/tool-group/tool-group.service.ts

frett

Sorry about the slow review, I'm not aware of any other outstanding issues unless the QA team raises anything

stage-branch-merger · 2023-12-07T21:39:00Z

Merge conflict attempting to merge this into staging. Please fix manually.

stage-branch-merger · 2023-12-07T21:41:44Z

Merge conflict attempting to merge this into staging. Please fix manually.

stage-branch-merger · 2023-12-08T12:54:06Z

Merge conflict attempting to merge this into staging. Please fix manually.

…assign countries, Languages and Praxis to them and then create relationships between ToolGroups and Tools. Only loading minimal data whe page loads. Load all Tool Group data when user selects Tool Group Created Service to handle all Tool Groups requests Add reuseable components to make mantaining simplier.

stage-branch-merger · 2023-12-08T20:32:44Z

Merge conflict attempting to merge this into staging. Please fix manually.

Also fixed the confusing hasMadeChanges and fixed error with praxis in that function.

…it no longer tries to refetch the deleted item.

frett · 2024-01-25T23:44:44Z

...pp/components/translation/translation-version-badge/translation-version-badge.component.html

  >{{ translation.version }} | Draft</span
 >
-<span class="badge badge-success" *ngIf="translation.is_published"
+<span class="badge badge-success" *ngIf="translation.is_published && !translation['publishing-errors']"


in theory if it's published it shouldn't actually have a publishing-error

I pushed this to the wrong PR, so I'm going to remove it and add it to the new publishing PR #700

dr-bizz · 2024-11-05T21:58:35Z

Closing this task as God Tools might now use this functionality.

dr-bizz changed the title ~~Gt 2095 tool groups~~ GT 2095 tool groups Oct 23, 2023

dr-bizz changed the title ~~GT 2095 tool groups~~ GT-2095 - Support creating & managing collections Tool Groups Oct 23, 2023

dr-bizz force-pushed the GT-2095-Tool-Groups branch from d69ace7 to a8a325b Compare October 23, 2023 19:04

dr-bizz added the On Staging label Oct 23, 2023

frett reviewed Oct 24, 2023

View reviewed changes

src/app/service/tool-group/tool-group.service.ts Outdated Show resolved Hide resolved

frett reviewed Oct 24, 2023

View reviewed changes

src/app/service/languages-bcp47-tag.service.ts Outdated Show resolved Hide resolved

frett reviewed Oct 24, 2023

View reviewed changes

src/app/components/edit-tool-group-tool-reuseable/tool-group-tool-reuseable.component.html Outdated Show resolved Hide resolved

dr-bizz force-pushed the GT-2095-Tool-Groups branch from 9283b9c to 081c141 Compare October 31, 2023 17:38

dr-bizz requested a review from frett October 31, 2023 17:38

dr-bizz marked this pull request as ready for review November 1, 2023 14:34

frett reviewed Nov 13, 2023

View reviewed changes

src/app/components/edit-tool-group-resource/tool-group-resource.component.html Outdated Show resolved Hide resolved

dr-bizz requested a review from frett November 20, 2023 15:59

frett reviewed Nov 28, 2023

View reviewed changes

src/app/components/edit-tool-group-resource/tool-group-resource.component.ts Outdated Show resolved Hide resolved

frett reviewed Nov 28, 2023

View reviewed changes

src/app/service/tool-group/tool-group.service.ts Outdated Show resolved Hide resolved

dr-bizz requested a review from frett December 1, 2023 17:24

frett approved these changes Dec 6, 2023

View reviewed changes

dr-bizz force-pushed the GT-2095-Tool-Groups branch from 4971b5b to 4880f37 Compare December 8, 2023 14:33

dr-bizz force-pushed the GT-2095-Tool-Groups branch from 4880f37 to 95e4203 Compare December 8, 2023 20:32

dr-bizz added 3 commits January 23, 2024 10:28

Prevent errors when initial data is undefined.

3ef78ec

Also fixed the confusing hasMadeChanges and fixed error with praxis in that function.

Fixed the error when deleting an item it fetches the item again. Now …

c6476e0

…it no longer tries to refetch the deleted item.

Adding error label on translated languages which had publishing errors

ea6cbcd

frett reviewed Jan 25, 2024

View reviewed changes

dr-bizz added 7 commits January 26, 2024 14:35

Removing error label as I got my PRs confused

273ad61

Prettier fixes

7d710ed

Adding better logging on update Tool Group modal

8f608d7

Using Prettier on update tool groups modal

b687374

Merge branch 'master' into GT-2095-Tool-Groups

edb0f1d

Fixing Praxis values sent to server (1-5)

e045d2f

Allow Praxis rules to be edited one at a time.

3255402

dr-bizz closed this Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GT-2095 - Support creating & managing collections Tool Groups #695

GT-2095 - Support creating & managing collections Tool Groups #695

dr-bizz commented Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 23, 2023 •

edited

Loading

stage-branch-merger bot commented Oct 23, 2023

frett commented Oct 24, 2023

dr-bizz commented Oct 25, 2023

frett left a comment

stage-branch-merger bot commented Dec 7, 2023

stage-branch-merger bot commented Dec 7, 2023

stage-branch-merger bot commented Dec 8, 2023

stage-branch-merger bot commented Dec 8, 2023

frett Jan 25, 2024

dr-bizz Jan 26, 2024 •

edited

Loading

dr-bizz commented Nov 5, 2024

GT-2095 - Support creating & managing collections Tool Groups #695

GT-2095 - Support creating & managing collections Tool Groups #695

Conversation

dr-bizz commented Oct 23, 2023 • edited Loading

Description

Changes

codecov bot commented Oct 23, 2023 • edited Loading

Codecov Report

stage-branch-merger bot commented Oct 23, 2023

frett commented Oct 24, 2023

dr-bizz commented Oct 25, 2023

frett left a comment

Choose a reason for hiding this comment

stage-branch-merger bot commented Dec 7, 2023

stage-branch-merger bot commented Dec 7, 2023

stage-branch-merger bot commented Dec 8, 2023

stage-branch-merger bot commented Dec 8, 2023

frett Jan 25, 2024

Choose a reason for hiding this comment

dr-bizz Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

dr-bizz commented Nov 5, 2024

dr-bizz commented Oct 23, 2023 •

edited

Loading

codecov bot commented Oct 23, 2023 •

edited

Loading

dr-bizz Jan 26, 2024 •

edited

Loading