Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Jira Rename tools to content and update the readme #705

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

caleballdrin
Copy link
Contributor

The GodTools team asked to rename 'Tools' to 'Content'.
I also updated the readme.

@caleballdrin caleballdrin requested a review from dr-bizz February 28, 2024 22:11
@caleballdrin caleballdrin self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.32%. Comparing base (5768719) to head (95eb590).
Report is 3 commits behind head on master.

Files Patch % Lines
...rc/app/components/resources/resources.component.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files          59       59           
  Lines        1482     1482           
  Branches      115      115           
=======================================
  Hits          983      983           
  Misses        481      481           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. thank you for fixing that one test. can you add this to staging so I can test it?

@dr-bizz dr-bizz self-requested a review March 1, 2024 19:18
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@caleballdrin caleballdrin merged commit 45becd0 into master Mar 1, 2024
4 checks passed
@caleballdrin caleballdrin deleted the rename-tools branch March 1, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants