Refactor nested ternary

CruGlobal · Jan 8, 2025 · 259374e · 259374e
1 parent 6eb69ac
commit 259374e
Showing 1 changed file with 18 additions and 12 deletions.
diff --git a/src/components/Settings/preferences/accordions/MonthlyGoalAccordion/MonthlyGoalAccordion.tsx b/src/components/Settings/preferences/accordions/MonthlyGoalAccordion/MonthlyGoalAccordion.tsx
@@ -110,19 +110,25 @@ export const MonthlyGoalAccordion: React.FC<MonthlyGoalAccordionProps> = ({
     handleSetupChange();
   };
 
-  const instructions = calculatedGoal
-    ? initialMonthlyGoal === null
-      ? t(
-          'Based on the past year, NetSuite estimates that you need at least {{goal}} of monthly support. You can choose your own target monthly goal or leave it blank to use the estimate.',
-          { goal: formattedCalculatedGoal },
-        )
-      : t(
-          'Based on the past year, NetSuite estimates that you need at least {{goal}} of monthly support. You can choose your own target monthly goal or reset it to the estimate.',
-          { goal: formattedCalculatedGoal },
-        )
-    : t(
+  const getInstructions = () => {
+    if (typeof calculatedGoal !== 'number') {
+      return t(
         'This amount should be set to the amount your organization has determined is your target monthly goal. If you do not know, make your best guess for now. You can change it at any time.',
       );
+    }
+
+    if (initialMonthlyGoal) {
+      return t(
+        'Based on the past year, NetSuite estimates that you need at least {{goal}} of monthly support. You can choose your own target monthly goal or leave it blank to use the estimate.',
+        { goal: formattedCalculatedGoal },
+      );
+    } else {
+      return t(
+        'Based on the past year, NetSuite estimates that you need at least {{goal}} of monthly support. You can choose your own target monthly goal or reset it to use the estimate.',
+        { goal: formattedCalculatedGoal },
+      );
+    }
+  };
 
   return (
     <AccordionItem
@@ -151,7 +157,7 @@ export const MonthlyGoalAccordion: React.FC<MonthlyGoalAccordionProps> = ({
           handleChange,
         }): ReactElement => (
           <form onSubmit={handleSubmit}>
-            <FieldWrapper helperText={instructions}>
+            <FieldWrapper helperText={getInstructions()}>
               <TextField
                 value={monthlyGoal}
                 onChange={handleChange}