Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HS-1276961 Remove deceased people from fix phone/email suggestions #1246

Merged
merged 1 commit into from
Jan 7, 2025
Merged

HS-1276961 Remove deceased people from fix phone/email suggestions #1246

merged 1 commit into from
Jan 7, 2025

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Jan 2, 2025 •
edited
Loading

Description

https://secure.helpscout.net/conversation/2796561763/1276961?viewId=7669074

  • Update graphql request to filter our people who are deceased or inactive.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Jan 2, 2025
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Jan 2, 2025
@caleballdrin caleballdrin requested a review from canac January 2, 2025 21:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Preview branch generated at https://hide-deceased-from-fix.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Bundle sizes [mpdx-react]

Compared against 51365b4

No significant changes found

canac
canac approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@caleballdrin caleballdrin merged commit e22a7c8 into main Jan 7, 2025
20 checks passed
@caleballdrin caleballdrin deleted the hide-deceased-from-fix branch January 7, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @canac