-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPDX-8511 - Restoring the Relationship Code field on contacts #1250
Conversation
Bundle sizes [mpdx-react]Compared against d633c2e
|
Preview branch generated at https://adding-relationship-back-to-mpdx.d3dytjb8adxkk5.amplifyapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Thanks for improving some of the tests.
I'm OK with the PNP change, but if yarn tries to change it again, we should probably try to dig into why.
...ntactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.test.tsx
Outdated
Show resolved
Hide resolved
@@ -8314,7 +8314,7 @@ function $$SETUP_STATE(hydrateRuntimeState, basePath) { | |||
]],\ | |||
["@surma/rollup-plugin-off-main-thread", [\ | |||
["npm:2.2.3", {\ | |||
"packageLocation": "./.yarn/unplugged/@surma-rollup-plugin-off-main-thread-npm-2.2.3-1f57d3eded/node_modules/@surma/rollup-plugin-off-main-thread/",\ | |||
"packageLocation": "./.yarn/cache/@surma-rollup-plugin-off-main-thread-npm-2.2.3-1f57d3eded-2c02134944.zip/node_modules/@surma/rollup-plugin-off-main-thread/",\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we change this back to how it once was, I'm wondering if yarn
is going to try to revert it back to unplugged later. I'm not sure whether unplugged or cache, is correct, but I've found that deleting .yarn/cache
at least makes yarn
stop making changes every time you run yarn
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After deleting ``.yarn/cacheand running
yarn` again, it made this change again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR merged, after pulling from main
, yarn
wants to revert it back to unplugged
on my machine. Is it doing that for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, yarn doesn't revert it back. weird.
… if the user can view/edit the relationship field on the modal.
36c3e78
to
ed08340
Compare
Description
In 2020, we added custom code to the contact details tab for the Switzland Cru. View the old MPDX Web PR
This code only allowed the Switzland Cru organization members to view and edit the "Relationship Code" field since they use this with their MailChimp integration.
In this PR, I have added the field back to the contacts page under the partnership info.
Blocked:
In order for this PR to be deployed, we need some GraphQL work completed. We need to add the field
relationshipCode
as an input underattributes
on theupdateContact
mutation.In our code, I have commented out code which is needed, but would break the site otherwise.
Links
HelpScout: https://secure.helpscout.net/conversation/2768772103/1262455?viewId=7296147
Jira: https://jira.cru.org/browse/MPDX-8511
Test
relationship code
field (In german "Beziehungsart")Checklist: