Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPDX-8514 + MPDX-7911 - Improve the Integrations page #1255

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jan 14, 2025

Description

In this PR, I change the "The Key" accordion wording on the Integrations page to "Okta". I also update the ministry organization warning when adding a ministry organization.

With the "The Key" change, I renamed files, folders and components, but both of these changes are pretty simple.

MPDX-7911
MPDX-8514
HelpScout

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from canac January 14, 2025 14:04
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jan 14, 2025
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against a4d5410

No significant changes found

Copy link
Contributor

Preview branch generated at https://change-add-org-text.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions, but I'm going to go ahead and approve.

value={''}
disabled={disabled}
image={
<img
src="/images/settings-preferences-intergrations-key.png"
alt="The Key"
src="/images/settings-preferences-intergrations-okta.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete settings-preferences-intergrations-key.png now?

FYI, there's a typo in the name intergrations --> integrations, but all the other images have the typo too.

@dr-bizz dr-bizz force-pushed the change-add-org-text branch from dca7764 to 7772d0f Compare January 14, 2025 18:32
@dr-bizz dr-bizz enabled auto-merge January 14, 2025 18:35
@dr-bizz dr-bizz merged commit d43b2c1 into main Jan 14, 2025
18 checks passed
@dr-bizz dr-bizz deleted the change-add-org-text branch January 14, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants