Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Relay pagination data loss #1259

Merged
merged 1 commit into from
Jan 16, 2025
Merged

[no-Jira] Relay pagination data loss #1259

merged 1 commit into from
Jan 16, 2025

Conversation

canac
Copy link
Contributor

@canac canac commented Jan 16, 2025

Description

Fix relayStylePaginationWithNodes sometimes discarding the first page of data.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Jan 16, 2025
@canac canac requested a review from dr-bizz January 16, 2025 20:32
@canac canac self-assigned this Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://relay-pagination-data-loss.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 7e336a6

No significant changes found

dr-bizz
dr-bizz approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is Awesome! thank you

@canac canac changed the base branch from remove-limit-from-fetching-coaches to main January 16, 2025 20:43
@canac canac force-pushed the relay-pagination-data-loss branch from 143406b to 2659235 Compare January 16, 2025 20:43
@canac canac enabled auto-merge January 16, 2025 20:44
@canac canac merged commit e7677b9 into main Jan 16, 2025
18 checks passed
@canac canac deleted the relay-pagination-data-loss branch January 16, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz