Implement object type tests #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ergo720
reviewed
Mar 4, 2024
ergo720
reviewed
Mar 4, 2024
ergo720
reviewed
Mar 4, 2024
ergo720
reviewed
Mar 4, 2024
RadWolfie
force-pushed
the
impl-object-types-test
branch
from
a2a9715 to
6edbb98
Compare
|
Rebased and added review remark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests has been implement:
All of the tests above have performed checks on member variables. Plus use relative calls purpose for their respective object creation to verify their object creations do match one of the above object types.
The tests had been passed on the hardware.
Note
Cxbx-Reloaded will crash for:1
PsThreadObjectType will not cause a crash due to xbox object implementation is completed and passed the test.
Footnotes
The reason for these crashes is due to not being implemented or currently using the host's objects which are exposed outside of the xbox kernel environment is forbidden. ↩