Add differentiae_database and make differentia-related fields searchable
#815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
reviewed
Jan 23, 2024
ahankinson
reviewed
Jan 23, 2024
ahankinson
reviewed
Jan 23, 2024
ahankinson
reviewed
Jan 23, 2024
dchiller
force-pushed
the
differentia-field
branch
from
5e4c23e to
f69c517
Compare
Add differentia and differentiae_database search fields Add differentia and differentiae_database to full text search
jacobdgm
reviewed
Jan 26, 2024
Comment on lines
+34
to
+36
| <% if (differentiae_database) { %> | ||
| <p><b>Differentiae Database: </b> <%= differentiae_database %></p> | ||
| <% } %> |
There was a problem hiding this comment.
Not required before merging, but - I appreciate the indentation in these lines! It would really help readability if such indentation was applied to the rest of the file.
(also - what templating language is this? I'm confused by the javascripty parens-with-braces for conditionals, but wrapped in <% %>...)
There was a problem hiding this comment.
The template language is underscore's I believe (underscore is a dependency of marionette) <% ... %> executes the javascript code at ...
jacobdgm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
differentiae_databasefield from CantusDB to the chant model (Closes Adddifferentiae_databaseto the chant model #805)differentiaanddifferentiae_databasefield searchable (Closes Provide field search for differentia data #804)