Codequality (#75)

src/include/JsonHandler.hpp

@@ -174,7 +174,7 @@ class JsonHandler {
     *
     * @bool If the string contains a bad char or not
     */
-    [[nodiscard]] static bool containsBadCharacter(const std::string &str);
+    [[nodiscard]] static bool containsBadCharacter(const std::string_view &str);
     std::shared_ptr<Json::Value> root;
     std::shared_ptr<FileData> data;
 };

src/include/Utils.hpp

@@ -107,7 +107,7 @@ class Utils {
     *
     * @return The processed string
     */
-    static const std::string escapeString(const std::string &str);
+    static std::string escapeString(const std::string &str);
 };
 } // namespace utilities
 

src/main.cpp

@@ -168,7 +168,7 @@ std::vector<std::string> validateFiles(const std::vector<std::string> &files) {
 
         // Check if the file ends in .json
         if (file.extension() != ".json") {
-            LOG_WARNING << "The file \"" << file << "\" does not end in \".json\"";
+            LOG_WARNING << "The file \"" << file << R"(" does not end in ".json")";
             OUTPUT << "If the file is not in JSON Format, continuing may "
                    "result in\nunexpected behaviour!\n";
 

src/sources/JsonHandler.cpp

@@ -151,7 +151,7 @@ void JsonHandler::assignPathValue(const Json::Value &entry) const {
     this->data->addPathValue(path);
 }
 
-bool JsonHandler::containsBadCharacter(const std::string &str) {
+bool JsonHandler::containsBadCharacter(const std::string_view &str) {
 
     // Set of characters which may not be in the string
     static const std::unordered_set<char> badChars = {
@@ -163,6 +163,6 @@ bool JsonHandler::containsBadCharacter(const std::string &str) {
         return badChars.contains(c);
     };
 
-    return std::any_of(str.begin(), str.end(), isBadCharacter);
+    return std::ranges::any_of(str, isBadCharacter);
 }
 } // namespace parsing

src/sources/Utils.cpp

@@ -94,7 +94,7 @@ bool Utils::handleParseException(const exceptions::CustomException &e,
     return true;
 }
 
-const std::string Utils::escapeString(const std::string &str) {
+std::string Utils::escapeString(const std::string &str) {
     // Map of characters to their escape sequences
     static const std::unordered_map<char, std::string> escapeSequences = {
         {'\\', "\\\\"},    // Replace backslash with double backslash